changes in UIETask to remove mutliple schema construction #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove import but unused os lib - use `_schema_tree` attribute to displace multiple times of schema tree construction - remove `schema_tree` arg in `_multi_stage_predict` - add early check & return in `_multi_stage_predict` - rename `id` var in `_multi_stage_predict` to `idx` to avoid mixing with python built-in funcs - change `_build_tree` func to python `classmethod`
|
|
linjieccc
approved these changes
May 16, 2022
ZeyuChen
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Enhancement as discussed in issue 2165.
PR changes
_schema_treeattribute to displace multiple times of schema tree constructionschema_treearg in_multi_stage_predict_multi_stage_predictidvar in_multi_stage_predicttoidxto avoid mixing with python built-in funcs_build_treefunc to pythonclassmethodDescription
Use an attribute
_schema_treeto avoid building schema tree on each call.Local test passed.