Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unexpected terminate and save the correct program for pipeline #2195

Merged
merged 3 commits into from
May 18, 2022
Merged

fix unexpected terminate and save the correct program for pipeline #2195

merged 3 commits into from
May 18, 2022

Conversation

sandyhouse
Copy link

@sandyhouse sandyhouse commented May 17, 2022 •
edited

PR types

Bug fixes

PR changes

Others

Description

  1. avoid unexpected terminate by calling train_data_loader.reset()
  2. use the correct program to save persistable for pipeline which is program._pipeline['section_program']

@ZeyuChen ZeyuChen requested a review from ZHUI May 17, 2022 16:25
ZHUI
ZHUI approved these changes May 18, 2022
View reviewed changes
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit d9431a8 into PaddlePaddle:develop May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZHUI ZHUI ZHUI approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sandyhouse @ZHUI