[BugFix] Deal with greek letter "sigma" when return offset_mapping #2897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joey12300
reviewed
Jul 27, 2022
| @@ -1363,7 +1363,13 @@ def get_offset_mapping(self, text): | |||
| if token in self.all_special_tokens: | |||
| token = token.lower() if hasattr( | |||
| self, "do_lower_case") and self.do_lower_case else token | |||
| start = text[offset:].index(token) + offset | |||
| # Deal with special greek letter with 2 forms (sigma) | |||
There was a problem hiding this comment.
可以加个特殊处理的说明，例如：
“The greek letter "sigma" has 2 types of lowercase. When used at the end of a letter-case word (one that does not use all caps), the final form (ς) is used. Otherwise, the form (σ) is used”
guoshengCS
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Models
Description
Fix #2854