Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to remove protobuf dependency #4600

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Try to remove protobuf dependency #4600

merged 1 commit into from
Feb 1, 2023

Conversation

sijunhe
Copy link
Collaborator

@sijunhe sijunhe commented Jan 31, 2023

PR types

PR changes

Description

#4572

@paddle-bot
Copy link

paddle-bot bot commented Jan 31, 2023

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #4600 (2d5b755) into develop (2abc332) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4600   +/-   ##
========================================
  Coverage    41.92%   41.92%           
========================================
  Files          434      434           
  Lines        61820    61820           
========================================
+ Hits         25918    25919    +1     
+ Misses       35902    35901    -1     
Impacted Files Coverage Δ
paddlenlp/utils/downloader.py 59.01% <0.00%> (+0.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sijunhe sijunhe marked this pull request as ready for review February 1, 2023 02:56
Copy link

@yt605155624 yt605155624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sijunhe sijunhe merged commit 6b0b8f9 into develop Feb 1, 2023
@sijunhe sijunhe deleted the sijunhe-patch-3 branch February 1, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants