Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoNLP] Add english models for text classification #4704

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

sijunhe
Copy link
Collaborator

@sijunhe sijunhe commented Feb 8, 2023

PR types

PR changes

Description

@sijunhe sijunhe requested a review from lugimzzz February 8, 2023 17:18
@paddle-bot
Copy link

paddle-bot bot commented Feb 8, 2023

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #4704 (41d483a) into develop (3ab7c61) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #4704   +/-   ##
========================================
  Coverage    42.97%   42.98%           
========================================
  Files          434      434           
  Lines        61956    61965    +9     
========================================
+ Hits         26626    26636   +10     
+ Misses       35330    35329    -1     
Impacted Files Coverage Δ
...addlenlp/experimental/autonlp/auto_trainer_base.py 89.51% <100.00%> (+0.44%) ⬆️
...dlenlp/experimental/autonlp/text_classification.py 98.12% <100.00%> (+1.97%) ⬆️
paddlenlp/utils/downloader.py 62.11% <0.00%> (-0.89%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -129,19 +133,42 @@ def _model_candidates(self) -> List[Dict[str, Any]]:
"ernie-3.0-nano-zh", # 4-layer, 312-hidden, 12-heads, 18M parameters.
],
)
english_models = hp.choice(
Copy link
Contributor

@lugimzzz lugimzzz Feb 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

添加英文模型的单测

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英文模型和中文模型逻辑一致,所以我没有添加新的测试。不过增加了test_model_language_filter来确保选英文能拿到英文模型的candidates

Copy link
Contributor

@lugimzzz lugimzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sijunhe sijunhe merged commit 3354848 into PaddlePaddle:develop Feb 9, 2023
@sijunhe sijunhe deleted the autonlp_english branch February 9, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants