Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utc] fix cls_positions #4785

Merged
merged 1 commit into from
Feb 14, 2023
Merged

[utc] fix cls_positions #4785

merged 1 commit into from
Feb 14, 2023

Conversation

LemonNoel
Copy link
Contributor

PR types

Bug fixes

PR changes

Models

Description

  • Fix the cls_positions gather operation in UTC.


cls_output = paddle.tensor.gather(flat_sequence_output, cls_positions)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对效果影响大吗?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

训练也是基于有问题的代码吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

小模型的效果有一定影响,在云上训练的代码没有问题。

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #4785 (5fa06c4) into develop (85f3d7c) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #4785   +/-   ##
========================================
  Coverage    43.92%   43.92%           
========================================
  Files          441      441           
  Lines        63171    63171           
========================================
  Hits         27747    27747           
  Misses       35424    35424           
Impacted Files Coverage Δ
paddlenlp/transformers/ernie/modeling.py 85.21% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@LemonNoel LemonNoel merged commit f9dbc4f into PaddlePaddle:develop Feb 14, 2023
@LemonNoel LemonNoel deleted the utc-fix branch March 23, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants