Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackathon No.106 add Stable Diffusion Pipeline Attend and excite #5296

Merged
merged 8 commits into from
Mar 27, 2023

Conversation

Yam0214
Copy link
Contributor

@Yam0214 Yam0214 commented Mar 18, 2023

PR types

Others

PR changes

APIs

Description

add StableDiffusionPipelineAttendAndExcite to ppdiffusers

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Merging #5296 (2b10e64) into develop (86c8848) will increase coverage by 3.29%.
The diff coverage is 90.00%.

❗ Current head 2b10e64 differs from pull request most recent head bafe269. Consider uploading reports for the commit bafe269 to get more accurate results

@@             Coverage Diff             @@
##           develop    #5296      +/-   ##
===========================================
+ Coverage    51.44%   54.73%   +3.29%     
===========================================
  Files          465      484      +19     
  Lines        66475    68921    +2446     
===========================================
+ Hits         34196    37724    +3528     
+ Misses       32279    31197    -1082     
Impacted Files Coverage Δ
paddlenlp/transformers/generation_utils.py 74.28% <85.71%> (-7.23%) ⬇️
paddlenlp/layers/lora.py 65.93% <88.67%> (ø)
paddlenlp/layers/__init__.py 100.00% <100.00%> (ø)
paddlenlp/layers/crf.py 51.26% <100.00%> (ø)
paddlenlp/transformers/model_outputs.py 95.38% <100.00%> (+0.18%) ⬆️

... and 98 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Yam0214 Yam0214 changed the title add Stable Diffusion Pipeline Attend and excite Hackathon + No.106 add Stable Diffusion Pipeline Attend and excite Mar 18, 2023
@Yam0214 Yam0214 changed the title Hackathon + No.106 add Stable Diffusion Pipeline Attend and excite Hackathon No.106 add Stable Diffusion Pipeline Attend and excite Mar 18, 2023
@sijunhe sijunhe requested a review from JunnYu March 18, 2023 07:34
@JunnYu
Copy link
Member

JunnYu commented Mar 20, 2023

总体来说对齐的很细致并进行了大量的对比实验,合入之前还需要对一些readme文档进行部分调整

@JunnYu
Copy link
Member

JunnYu commented Mar 23, 2023

建议把这些readme可以放到example里面,比如加个reproduce文件夹,然后把你对齐的信息加进去

Copy link
Member

@JunnYu JunnYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JunnYu JunnYu merged commit c2b8481 into PaddlePaddle:develop Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants