Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 4th No.102】给AutoConverter增加新的模型组网的支持 Bart #5668

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

megemini
Copy link
Contributor

@megemini megemini commented Apr 14, 2023

PR types

New features

PR changes

APIs

Description

【Hackathon 4th No.102】给AutoConverter增加新的模型组网的支持 Bart

Hackathon 4th No.102 这个任务里面有5个模型,我计划每个模型单独提PR,这个PR是处理 bart 模型。

  • 使用的测试模型 hf-internal-testing/tiny-random-BartModel

@wj-Mcat @sijunhe 请评审,谢谢!:)

@paddle-bot
Copy link

paddle-bot bot commented Apr 14, 2023

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #5668 (0d65504) into develop (848f5c1) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #5668      +/-   ##
===========================================
+ Coverage    59.60%   59.68%   +0.08%     
===========================================
  Files          483      482       -1     
  Lines        68134    68098      -36     
===========================================
+ Hits         40610    40644      +34     
+ Misses       27524    27454      -70     
Impacted Files Coverage Δ
paddlenlp/transformers/bart/modeling.py 85.51% <100.00%> (+1.34%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@sijunhe sijunhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!
麻烦顺道删除bart/converter.py

@megemini
Copy link
Contributor Author

looks good! 麻烦顺道删除bart/converter.py

已删除~

Copy link
Collaborator

@sijunhe sijunhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sijunhe sijunhe merged commit 9d25528 into PaddlePaddle:develop Apr 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants