Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error in dropout of hybrid_model #7269

Merged
merged 1 commit into from Oct 18, 2023

Conversation

heavyrain-lzy
Copy link
Contributor

@heavyrain-lzy heavyrain-lzy commented Oct 18, 2023

PR types

Bug fixes

PR changes

Models

Description

Fix the bug in hybrid_model.py in the case of 'not self.use_fused_dropout_add'.
Fixed the bug, test the hybrid_model using pp4-mp2. After 10 steps the losses are as follow:

scene loss
use_fused_dropout_add 11.255878448
not use_fused_dropout_add(fixed bug) 11.255878448
not use_fused_dropout_add(origin) 11.210844040

@paddle-bot
Copy link

paddle-bot bot commented Oct 18, 2023

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #7269 (e8247b5) into develop (af0d26a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #7269   +/-   ##
========================================
  Coverage    59.34%   59.34%           
========================================
  Files          567      567           
  Lines        83355    83355           
========================================
  Hits         49466    49466           
  Misses       33889    33889           

Copy link
Collaborator

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiqiu zhiqiu merged commit 90f44a9 into PaddlePaddle:develop Oct 18, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants