Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _cache_founf_inf #7997

Merged
merged 4 commits into from Mar 4, 2024
Merged

Fix _cache_founf_inf #7997

merged 4 commits into from Mar 4, 2024

Conversation

co63oc
Copy link
Contributor

@co63oc co63oc commented Feb 21, 2024

PR types

Others

PR changes

Others

Description

Fix _cache_founf_inf

Paddle也需要修改 PaddlePaddle/Paddle#61954

Copy link

paddle-bot bot commented Feb 21, 2024

Thanks for your contribution!

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 56.55%. Comparing base (b72f352) to head (68f8a06).
Report is 4 commits behind head on develop.

Files Patch % Lines
paddlenlp/trainer/auto_trainer.py 0.00% 3 Missing ⚠️
paddlenlp/trainer/trainer.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7997      +/-   ##
===========================================
+ Coverage    56.42%   56.55%   +0.13%     
===========================================
  Files          589      592       +3     
  Lines        90252    91040     +788     
===========================================
+ Hits         50921    51484     +563     
- Misses       39331    39556     +225     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -415,7 +415,7 @@ def full_training_step(self: Trainer, inputs: Dict[str, paddle.Tensor], **kwargs
self.scaler.step(self.optimizer)
self.scaler.update()
scale_after = self.scaler._scale
optimizer_was_run = not self.scaler._cache_founf_inf
optimizer_was_run = not self.scaler._cache_found_inf
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if there's a way to ensure compatibility between interfaces. We've encountered an issue where using PaddleNLP's development version with PaddlePaddle v2.6.0 results in incompatibility.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Changed to check _cache_founf_inf

@co63oc
Copy link
Contributor Author

co63oc commented Mar 1, 2024

@wawltor It has been modified. codecov suggested that there was a coverage problem. Do I need to add the test, Where is it to add

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 77a23d1 into PaddlePaddle:develop Mar 4, 2024
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants