Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add RoFormer Model #804

Merged
merged 16 commits into from
Aug 2, 2021
Merged

add RoFormer Model #804

merged 16 commits into from
Aug 2, 2021

Conversation

JunnYu
Copy link
Member

@JunnYu JunnYu commented Jul 27, 2021

PR types

PR changes

Description

添加RoFormer模型

@ZeyuChen ZeyuChen requested a review from yingyibiao July 27, 2021 10:21
@ZeyuChen ZeyuChen added the enhancement New feature or request label Jul 27, 2021
@ZeyuChen ZeyuChen added this to In progress in PaddleNLP 2.1 via automation Jul 27, 2021
ZeyuChen
ZeyuChen reviewed Jul 27, 2021
View reviewed changes
Copy link
Member

@ZeyuChen ZeyuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add an example of RoFormer to paddlenlp's examples. eg.

https://github.com/PaddlePaddle/PaddleNLP/tree/develop/examples/language_model/roformer

And also please provide more pretrained weight sent to @yingyibiao, we will help you upload the pretrained weight of RoFromer.

@JunnYu
Copy link
Member Author

JunnYu commented Jul 28, 2021

@yingyibiao
麻烦添加一下有关的roformer权重，谢谢
https://drive.google.com/file/d/1-j_gCJ3oYjiGMG6ISfnrhQIzoe3h0bwH/view

@yingyibiao
Copy link
Contributor

yingyibiao commented Jul 28, 2021 •
edited
Loading

@yingyibiao
麻烦添加一下有关的roformer权重，谢谢
https://drive.google.com/file/d/1-j_gCJ3oYjiGMG6ISfnrhQIzoe3h0bwH/view

done

yingyibiao
yingyibiao reviewed Jul 28, 2021
View reviewed changes
paddlenlp/transformers/roformer/modeling.py Outdated Show resolved Hide resolved
paddlenlp/transformers/roformer/__init__.py Outdated Show resolved Hide resolved
paddlenlp/transformers/roformer/modeling.py Outdated Show resolved Hide resolved
paddlenlp/transformers/roformer/tokenizer.py Outdated Show resolved Hide resolved
paddlenlp/transformers/roformer/tokenizer.py Outdated Show resolved Hide resolved
@JunnYu JunnYu requested a review from yingyibiao July 28, 2021 16:15
@yingyibiao
Copy link
Contributor

please install pre-commit to format code style e.g.: pip install pre-commit & pre-commit install

@JunnYu
Copy link
Member Author

JunnYu commented Jul 30, 2021 •
edited
Loading

please install pre-commit to format code style e.g.: pip install pre-commit & pre-commit install

@yingyibiao
你好，我pip install pre-commit & pre-commit install ，然后提交的时候发现没反应
image

@yingyibiao
Copy link
Contributor

please install pre-commit to format code style e.g.: pip install pre-commit & pre-commit install

@yingyibiao
你好，我pip install pre-commit & pre-commit install ，然后提交的时候发现没反应
image

可以对每个文件做一些格式上的小修改，然后重新提交～

yingyibiao
yingyibiao reviewed Jul 30, 2021
View reviewed changes
Copy link
Contributor

@yingyibiao yingyibiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

converter这个目录可以删除，这个是遗留的老代码

@JunnYu
Copy link
Member Author

JunnYu commented Jul 30, 2021

@yingyibiao
done
image

yingyibiao
yingyibiao reviewed Jul 30, 2021
View reviewed changes
paddlenlp/transformers/roformer/modeling.py Outdated Show resolved Hide resolved
paddlenlp/transformers/roformer/modeling.py Outdated Show resolved Hide resolved
paddlenlp/transformers/roformer/modeling.py Outdated Show resolved Hide resolved
paddlenlp/transformers/roformer/modeling.py Show resolved Hide resolved
yingyibiao
yingyibiao reviewed Jul 30, 2021
View reviewed changes
paddlenlp/transformers/roformer/tokenizer.py Outdated Show resolved Hide resolved
paddlenlp/transformers/roformer/tokenizer.py Outdated Show resolved Hide resolved
paddlenlp/transformers/roformer/tokenizer.py Outdated Show resolved Hide resolved
paddlenlp/transformers/roformer/tokenizer.py Outdated Show resolved Hide resolved
paddlenlp/transformers/roformer/tokenizer.py Outdated Show resolved Hide resolved
paddlenlp/transformers/roformer/tokenizer.py Outdated Show resolved Hide resolved
paddlenlp/transformers/roformer/tokenizer.py Outdated Show resolved Hide resolved
paddlenlp/transformers/roformer/tokenizer.py Outdated Show resolved Hide resolved
yingyibiao
yingyibiao reviewed Jul 30, 2021
View reviewed changes
Copy link
Contributor

@yingyibiao yingyibiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议增加一个论文上的CAIL2019-SCM任务的example

@JunnYu JunnYu requested a review from yingyibiao July 31, 2021 09:37
yingyibiao
yingyibiao reviewed Aug 2, 2021
View reviewed changes
examples/language_model/roformer/README.md Outdated Show resolved Hide resolved
examples/language_model/roformer/README.md Outdated Show resolved Hide resolved
examples/language_model/roformer/README.md Outdated Show resolved Hide resolved
examples/language_model/roformer/run_thucnews.py Outdated Show resolved Hide resolved
examples/language_model/roformer/README.md Outdated Show resolved Hide resolved
yingyibiao
yingyibiao reviewed Aug 2, 2021
View reviewed changes
Copy link
Contributor

@yingyibiao yingyibiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

yingyibiao
yingyibiao approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@yingyibiao yingyibiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PaddleNLP 2.1 automation moved this from In progress to Reviewer approved Aug 2, 2021
@yingyibiao yingyibiao merged commit b9058c0 into PaddlePaddle:develop Aug 2, 2021
PaddleNLP 2.1 automation moved this from Reviewer approved to Done Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeyuChen ZeyuChen ZeyuChen left review comments

@yingyibiao yingyibiao yingyibiao approved these changes

Assignees

@yingyibiao yingyibiao

Labels
enhancement New feature or request
Projects
No open projects
PaddleNLP 2.1
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JunnYu @yingyibiao @ZeyuChen