Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ConvBert Model #819

Merged
merged 20 commits into from
Sep 8, 2021
Merged

add ConvBert Model #819

merged 20 commits into from
Sep 8, 2021

Conversation

JunnYu
Copy link
Member

@JunnYu JunnYu commented Jul 29, 2021

Description

Add new model ConvBert
paddle model weights
https://drive.google.com/file/d/1rLiDxeiM3wXEZQ7WuRpFDcWwYOs6OgQo/view?usp=sharing

@yingyibiao yingyibiao self-assigned this Jul 30, 2021
@ZeyuChen ZeyuChen requested a review from yingyibiao July 30, 2021 06:01
@yingyibiao
Copy link
Contributor

Description

Add new model ConvBert
paddle model weights
https://drive.google.com/file/d/1rLiDxeiM3wXEZQ7WuRpFDcWwYOs6OgQo/view?usp=sharing

权重已上传

@ZeyuChen ZeyuChen added the enhancement New feature or request label Jul 30, 2021
@ZeyuChen ZeyuChen added this to In progress in PaddleNLP 2.1 via automation Jul 30, 2021
@chenxiaozeng
Copy link
Contributor

chenxiaozeng commented Aug 2, 2021 •
edited
Loading

@JunnYu Thanks for your contribution! Hope to have futrher communication with you.
Weclome to email us by Paddle-better@baidu.com or leave behind your contact method. Thank you!

@JunnYu
Copy link
Member Author

JunnYu commented Aug 2, 2021

@chenxiaozeng I have sent to the Paddle-better@baidu.com. Please check the email.

@gongel gongel self-requested a review August 27, 2021 06:58
gongel
gongel requested changes Aug 30, 2021
View reviewed changes
Copy link
Member

@gongel gongel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete compare.py before merging.

paddlenlp/transformers/convbert/modeling.py Outdated Show resolved Hide resolved
PaddleNLP 2.1 automation moved this from In progress to Review in progress Aug 30, 2021
@gongel
Copy link
Member

gongel commented Aug 30, 2021

😊 Please add class ConvBertForMultipleChoice and class ConvBertForQuestionAnswering.

@yingyibiao yingyibiao assigned gongel and unassigned yingyibiao Aug 30, 2021
gongel
gongel requested changes Aug 30, 2021
View reviewed changes
paddlenlp/transformers/convbert/modeling.py Outdated Show resolved Hide resolved
paddlenlp/transformers/convbert/modeling.py Outdated Show resolved Hide resolved
paddlenlp/transformers/convbert/modeling.py Outdated Show resolved Hide resolved
@gongel
Copy link
Member

gongel commented Aug 31, 2021

LGTM. @JunnYu Thanks for your contribution again! 😊

gongel
gongel previously approved these changes Aug 31, 2021
View reviewed changes
PaddleNLP 2.1 automation moved this from Review in progress to Reviewer approved Aug 31, 2021
@yingyibiao
Copy link
Contributor

Please add docstrings for all your classes and methods which might be utilized by users. You can refer to paddlenlp.transformers.bert.

gongel
gongel reviewed Aug 31, 2021
View reviewed changes
paddlenlp/transformers/convbert/modeling.py
if position_ids is not None:
position_ids = position_ids.reshape((-1, position_ids.shape[-1]))
if attention_mask is not None:
attention_mask = attention_mask.reshape(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If reshape attention_mask , ConvBertModel should support attention_mask.ndim == 2

yingyibiao
yingyibiao reviewed Sep 1, 2021
View reviewed changes
Copy link
Contributor

@yingyibiao yingyibiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add docstrings for all your classes and methods which might be utilized by users. You can refer to paddlenlp.transformers.bert.

@gongel gongel dismissed their stale review September 3, 2021 07:17

Need to process attention_mask and add docstrings.

PaddleNLP 2.1 automation moved this from Reviewer approved to Review in progress Sep 3, 2021
yingyibiao
yingyibiao approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@yingyibiao yingyibiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PaddleNLP 2.1 automation moved this from Review in progress to Reviewer approved Sep 8, 2021
@yingyibiao yingyibiao merged commit 0c751f3 into PaddlePaddle:develop Sep 8, 2021
PaddleNLP 2.1 automation moved this from Reviewer approved to Done Sep 8, 2021
@JunnYu JunnYu deleted the add_convbert branch September 8, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongel gongel gongel approved these changes

@yingyibiao yingyibiao yingyibiao approved these changes

Assignees

@gongel gongel

Labels
enhancement New feature or request
Projects
No open projects
PaddleNLP 2.1
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JunnYu @yingyibiao @chenxiaozeng @gongel @ZeyuChen