[XPU] llama add xpu support #8282

dynamicheart · 2024-04-17T07:28:10Z

PR types

New features

PR changes

Models

Description

Llama model supports XPU
简要说明：XPU自定义的融合算子通过Paddle C++ Extension的方式接入，XPU自定义Paddle算子库的名称叫做paddle_xpu(aka. fast_paddle)

paddle-bot · 2024-04-17T07:28:15Z

Thanks for your contribution!

codecov · 2024-04-17T09:04:36Z

Codecov Report

Attention: Patch coverage is 42.50000% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 55.35%. Comparing base (273c593) to head (6e0316a).
Report is 8 commits behind head on develop.

Files	Patch %	Lines
paddlenlp/transformers/llama/modeling.py	39.21%	31 Missing ⚠️
paddlenlp/transformers/linear_utils.py	48.27%	15 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #8282      +/-   ##
===========================================
+ Coverage    55.25%   55.35%   +0.10%     
===========================================
  Files          613      614       +1     
  Lines        95626    95924     +298     
===========================================
+ Hits         52837    53103     +266     
- Misses       42789    42821      +32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cqulilujia · 2024-04-22T03:36:49Z

LGTM

dynamicheart · 2024-04-22T03:42:02Z

paddlenlp/transformers/llama/modeling.py

+            x = paddle.to_tensor(0.0, dtype=dtype)
+            y = paddle.to_tensor(paddle.finfo(dtype).min, dtype=dtype)
+            expanded_attn_mask = expanded_attn_mask.astype(dtype)
+            expanded_attn_mask = paddle.where(expanded_attn_mask, x, y).astype(dtype)


当传入的x和y是整型scalar类型时，paddle.where 会将其视为int64、形状[1]的tensor，并会进行broadcast_add操作，详见search.py

llm/run_pretrain.py

paddlenlp/transformers/llama/modeling.py

ZibinGuo

LGTM

wuhuachaocoding · 2024-04-24T06:29:06Z

LGTM

paddlenlp/transformers/llama/modeling.py

ZHUI · 2024-04-24T08:19:31Z

llm/run_pretrain.py

+            LinearConfig.enable_accumulate_steps_opt()
+            LinearConfig.set_accumulate_steps(training_args.gradient_accumulation_steps)
+        except ImportError:
+            pass


这个是做什么的？

XPU针对accumulate_steps > 1的场景进行优化，配合下面的paddle_xpu里面的Linear层进行使用

…nto xpu_llama

paddlenlp/transformers/linear_utils.py

ZHUI · 2024-04-25T03:57:32Z

paddlenlp/transformers/llama/modeling.py

+            x = paddle.to_tensor(0.0, dtype=dtype)
+            y = paddle.to_tensor(paddle.finfo(dtype).min, dtype=dtype)
+            expanded_attn_mask = expanded_attn_mask.astype(dtype)
+            expanded_attn_mask = paddle.where(expanded_attn_mask, x, y).astype(dtype)


这里和上面 npu 的逻辑看着差不多，可以复用吗？

理论上是可以复用的，但是npu里面写死了dtype是float16，xpu跑的程序是可能是float16，也可能是bfloat16的。我们需要修改npu的模块么？

@SylarTiaNII 看一下？

根据 @wuhuachaocoding 意见，还是分成if elif两个单独的分支

ZHUI · 2024-04-25T03:59:43Z

paddlenlp/transformers/llama/modeling.py

+            logits = self.xpu_parallel_matmul(
+                hidden_states, self.weight, tensor_parallel_output=tensor_parallel_output, training=self.training


training 参数必须要吗？如果参数能一样的话，是不是把 parallel_matmul 的实现在xpu下替换就好了？

这里面有两个原因：

XPU的一个优化是需要将parallel_matmul作为一个对象来存储某些状态

XPU需要training信息来进行优化

ZHUI

LGTM

dynamicheart force-pushed the xpu_llama branch from 41cc029 to 160c79d Compare April 17, 2024 08:35

dynamicheart force-pushed the xpu_llama branch from 160c79d to 72ef18a Compare April 18, 2024 06:57

dynamicheart added 2 commits April 20, 2024 16:43

[XPU] llama add xpu support

1293619

fix

e388ed6

dynamicheart force-pushed the xpu_llama branch from 2a94e66 to e388ed6 Compare April 20, 2024 08:44

dynamicheart commented Apr 22, 2024

View reviewed changes

QingshuChen reviewed Apr 22, 2024

View reviewed changes

llm/run_pretrain.py Outdated Show resolved Hide resolved

paddlenlp/transformers/llama/modeling.py Outdated Show resolved Hide resolved

use try import

41421f4

dynamicheart closed this Apr 22, 2024

dynamicheart reopened this Apr 22, 2024

ZibinGuo reviewed Apr 22, 2024

View reviewed changes

fix

e9a4b87

dynamicheart closed this Apr 22, 2024

dynamicheart reopened this Apr 22, 2024

dynamicheart closed this Apr 22, 2024

dynamicheart reopened this Apr 22, 2024

ZHUI reviewed Apr 24, 2024

View reviewed changes

dynamicheart added 2 commits April 24, 2024 18:08

refine

2a8c639

Merge branch 'develop' of https://github.com/PaddlePaddle/PaddleNLP i…

d9dcdbe

…nto xpu_llama

ZHUI reviewed Apr 25, 2024

View reviewed changes

dynamicheart added 3 commits April 25, 2024 20:16

refine

40c23a5

refine

a3935fd

refine

6e0316a

ZHUI approved these changes Apr 28, 2024

View reviewed changes

sijunhe approved these changes Apr 29, 2024

View reviewed changes

sijunhe merged commit ba9d9bd into PaddlePaddle:develop Apr 29, 2024
8 of 11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[XPU] llama add xpu support #8282

[XPU] llama add xpu support #8282

dynamicheart commented Apr 17, 2024 •

edited

paddle-bot bot commented Apr 17, 2024

codecov bot commented Apr 17, 2024 •

edited

cqulilujia commented Apr 22, 2024

dynamicheart Apr 22, 2024

ZibinGuo left a comment

wuhuachaocoding commented Apr 24, 2024

ZHUI Apr 24, 2024

dynamicheart Apr 24, 2024

ZHUI Apr 25, 2024

dynamicheart Apr 25, 2024

ZHUI Apr 26, 2024

dynamicheart Apr 26, 2024

ZHUI Apr 25, 2024

dynamicheart Apr 25, 2024

ZHUI left a comment

		logits = self.xpu_parallel_matmul(
		hidden_states, self.weight, tensor_parallel_output=tensor_parallel_output, training=self.training

[XPU] llama add xpu support #8282

[XPU] llama add xpu support #8282

Conversation

dynamicheart commented Apr 17, 2024 • edited

PR types

PR changes

Description

paddle-bot bot commented Apr 17, 2024

codecov bot commented Apr 17, 2024 • edited

Codecov Report

cqulilujia commented Apr 22, 2024

Choose a reason for hiding this comment

ZibinGuo left a comment

Choose a reason for hiding this comment

wuhuachaocoding commented Apr 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ZHUI left a comment

Choose a reason for hiding this comment

dynamicheart commented Apr 17, 2024 •

edited

codecov bot commented Apr 17, 2024 •

edited