[DistDataloader] Update implementation, add nested.py #8380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
DesmonDay
force-pushed
the
update_distloader
branch
from
a1378a3
to
ac3f1aa
Compare
ZHUI
previously approved these changes
May 7, 2024
| data = None | ||
| if self._need_data: | ||
| try: | ||
| data = next(self._dataloader_iter) |
There was a problem hiding this comment.
copy可以放到这里
Suggested change
| data = next(self._dataloader_iter) | |
| data = next(self._dataloader_iter) | |
| data = nested_copy_place(data, place=paddle.framework._current_expected_place()) |
paddlenlp/data/dist_dataloader.py
Outdated
| nested_copy_place, | ||
| nested_empty_tensor, | ||
| nested_reduce_tensor, | ||
| ) | ||
|
|
||
| _MAX_DATA_DIM = 64 |
DesmonDay
force-pushed
the
update_distloader
branch
from
dabda13
to
84b4bf7
Compare
ZHUI
reviewed
May 8, 2024
paddlenlp/trainer/trainer.py
Outdated
| num_workers=self.args.dataloader_num_workers, | ||
| ) | ||
| if self.args.distributed_dataloader: | ||
| return _DataLoader( |
There was a problem hiding this comment.
既然都这样了，这里就直接 DistDataLoader 吧
删掉_DataLoader = DistDataLoader if self.args.distributed_dataloader else DataLoader
ZHUI
previously approved these changes
May 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8380 +/- ##
===========================================
+ Coverage 55.42% 55.43% +0.01%
===========================================
Files 615 616 +1
Lines 96235 96209 -26
===========================================
+ Hits 53335 53336 +1
+ Misses 42900 42873 -27 ☔ View full report in Codecov by Sentry. |
ZHUI
approved these changes
May 9, 2024
DesmonDay
added a commit
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description