add llama & qwen dpo #8474
Merged
add llama & qwen dpo #8474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8474 +/- ##
===========================================
- Coverage 54.29% 54.02% -0.27%
===========================================
Files 617 621 +4
Lines 96339 96878 +539
===========================================
+ Hits 52310 52343 +33
- Misses 44029 44535 +506 ☔ View full report in Codecov by Sentry. |
wawltor
reviewed
May 22, 2024
llm/utils.py
Outdated
| @@ -211,13 +211,6 @@ def prediction_step( | |||
| # keepdim in order to maintain the same shape as logits | |||
| if isinstance(logits, (list, tuple)): | |||
| logits = logits[0] | |||
| # all gather logits when enabling tensor_parallel_output | |||
There was a problem hiding this comment.
这里删除tensor parallel output的支持的原因是什么？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Description
新增dpo