Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Support Sharding Overlap (#8473)" #8491

Merged
merged 1 commit into from
May 24, 2024

Conversation

SylarTiaNII
Copy link
Contributor

This reverts commit 7aaa788.

PR types

Bug fixes

PR changes

Others

Description

Revert PR#8473 to fix llama

Copy link

paddle-bot bot commented May 24, 2024

Thanks for your contribution!

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 54.28%. Comparing base (7aaa788) to head (3a34b65).

Files Patch % Lines
paddlenlp/transformers/llama/modeling.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8491      +/-   ##
===========================================
+ Coverage    54.25%   54.28%   +0.02%     
===========================================
  Files          617      617              
  Lines        96368    96356      -12     
===========================================
+ Hits         52288    52306      +18     
+ Misses       44080    44050      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 0cd8fe7 into PaddlePaddle:develop May 24, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants