Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry pick] Sharding reshard function enhancement #8544

Merged
merged 7 commits into from
Jun 11, 2024

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Jun 5, 2024

PR types

Function optimization

PR changes

Others

Description

Sharding reshard function enhancement from paddle-dev-fleetv branch.

Copy link

paddle-bot bot commented Jun 5, 2024

Thanks for your contribution!

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 3.44828% with 28 lines in your changes missing coverage. Please review.

Project coverage is 53.85%. Comparing base (5a6d0fa) to head (c49207b).
Report is 5 commits behind head on develop.

Files Patch % Lines
paddlenlp/trainer/trainer.py 0.00% 17 Missing ⚠️
paddlenlp/trainer/utils/sharding_io.py 8.33% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8544      +/-   ##
===========================================
- Coverage    53.87%   53.85%   -0.02%     
===========================================
  Files          620      620              
  Lines        97080    97098      +18     
===========================================
- Hits         52300    52293       -7     
- Misses       44780    44805      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy requested a review from ZHUI June 7, 2024 00:47
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit bcacc6a into PaddlePaddle:develop Jun 11, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants