Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak bug #8546

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Jun 5, 2024

PR types

Bug fixes

PR changes

Others

Description

Fix memory leak bug of PaddleNLP.

Copy link

paddle-bot bot commented Jun 5, 2024

Thanks for your contribution!

@sneaxiy sneaxiy requested a review from ZHUI June 5, 2024 04:21
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.96%. Comparing base (f36ed75) to head (9ece15e).

Files Patch % Lines
paddlenlp/trainer/trainer.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8546      +/-   ##
===========================================
- Coverage    53.97%   53.96%   -0.01%     
===========================================
  Files          618      618              
  Lines        96827    96826       -1     
===========================================
- Hits         52258    52255       -3     
- Misses       44569    44571       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 5a6d0fa into PaddlePaddle:develop Jun 6, 2024
8 of 12 checks passed
@sneaxiy sneaxiy deleted the fix_mem_leak_bug branch June 6, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants