Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX DDP] fix ddp #8549

Merged
merged 5 commits into from
Jun 7, 2024
Merged

[FIX DDP] fix ddp #8549

merged 5 commits into from
Jun 7, 2024

Conversation

ZHUI
Copy link
Collaborator

@ZHUI ZHUI commented Jun 5, 2024

PR types

Others

PR changes

Others

Description

Others

Copy link

paddle-bot bot commented Jun 5, 2024

Thanks for your contribution!

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.96%. Comparing base (79e8b6e) to head (5d34b49).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8549      +/-   ##
===========================================
+ Coverage    53.86%   54.96%   +1.10%     
===========================================
  Files          620      620              
  Lines        97090    97109      +19     
===========================================
+ Hits         52298    53377    +1079     
+ Misses       44792    43732    -1060     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -1795,17 +1795,8 @@ def _wrap_model(self, model, training=True):
in_cp_parallel_mode = self.args.context_parallel_degree > 1

# Multi-gpu training
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个地方需要合入到2.8吗?

Copy link
Contributor

@DesmonDay DesmonDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit f89c91d into PaddlePaddle:develop Jun 7, 2024
8 of 12 checks passed
@ZHUI ZHUI deleted the fix/ddp branch June 7, 2024 06:53
ZHUI added a commit to ZHUI/PaddleNLP that referenced this pull request Jun 7, 2024
* enable trainer tests.
DesmonDay pushed a commit that referenced this pull request Jun 7, 2024
* [Safetensors] Fix fast safe open slice. (#8512)
* [FIX DDP] fix ddp (#8549)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants