Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_json_string兼容性升级 #8608

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Jun 17, 2024

PR types

Bug fixes

PR changes

Others

Description

to_json_string函数接口做兼容性升级。

Copy link

paddle-bot bot commented Jun 17, 2024

Thanks for your contribution!

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.41%. Comparing base (0844a5b) to head (e8456d8).

Files Patch % Lines
paddlenlp/transformers/configuration_utils.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8608   +/-   ##
========================================
  Coverage    54.41%   54.41%           
========================================
  Files          632      632           
  Lines        99475    99481    +6     
========================================
+ Hits         54127    54132    +5     
- Misses       45348    45349    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy merged commit c134a7f into PaddlePaddle:develop Jun 17, 2024
9 of 12 checks passed
@sneaxiy sneaxiy deleted the compat_to_json_string branch June 17, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants