Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yuan model #8654

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Add yuan model #8654

wants to merge 12 commits into from

Conversation

zhaogf01
Copy link

PR types

New features

PR changes

Models

Description

添加了源2.0的模型结构、配置等相关文件

Copy link

paddle-bot bot commented Jun 25, 2024

Thanks for your contribution!

@DrownFish19
Copy link
Collaborator

Lint问题可以参考link进行修复

@zhaogf01
Copy link
Author

我看lint的日志中引起black、isort、copyright_checker failed的文件已经被修改了,请问我还需要修改吗?或者这个错误具体指什么?我没看到引起错误的源文件?
另外,test中的错误需要处理吗?请问这个错误具体是指哪个文件?我没太看懂。

@DrownFish19
Copy link
Collaborator

DrownFish19 commented Jun 25, 2024

我看lint的日志中引起black、isort、copyright_checker failed的文件已经被修改了,请问我还需要修改吗?或者这个错误具体指什么?我没看到引起错误的源文件?

具体是格式错误问题,PR中的文件需要满足要求格式。可以本地使用pip install pre-commit && pre-commit install并使用pre-commit run --file XXX.py格式化本地代码并上传。

另外,test中的错误需要处理吗?请问这个错误具体是指哪个文件?我没太看懂。

辛苦拉一下最近代码即可,最新commit已经修复。

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 14.35331% with 543 lines in your changes missing coverage. Please review.

Project coverage is 55.53%. Comparing base (65e721e) to head (8b7878b).
Report is 7 commits behind head on develop.

Files Patch % Lines
paddlenlp/transformers/yuan/modeling.py 13.46% 527 Missing ⚠️
paddlenlp/transformers/yuan/configuration.py 23.80% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8654      +/-   ##
===========================================
- Coverage    55.80%   55.53%   -0.28%     
===========================================
  Files          620      623       +3     
  Lines        96642    97276     +634     
===========================================
+ Hits         53928    54019      +91     
- Misses       42714    43257     +543     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaogf01
Copy link
Author

请问目前的三个failed应该如何修改?

# See the License for the specific language governing permissions and
# limitations under the License.

""" Yuan model tools"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这串代码建议封装成函数,避免出现2,24这样的魔鬼数字,明文模型路径等;
建议搞成参数传入;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants