-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yuan model #8654
base: develop
Are you sure you want to change the base?
Add yuan model #8654
Conversation
Thanks for your contribution! |
Lint问题可以参考link进行修复 |
我看lint的日志中引起black、isort、copyright_checker failed的文件已经被修改了,请问我还需要修改吗?或者这个错误具体指什么?我没看到引起错误的源文件? |
具体是格式错误问题,PR中的文件需要满足要求格式。可以本地使用
辛苦拉一下最近代码即可,最新commit已经修复。 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8654 +/- ##
===========================================
- Coverage 55.80% 55.53% -0.28%
===========================================
Files 620 623 +3
Lines 96642 97276 +634
===========================================
+ Hits 53928 54019 +91
- Misses 42714 43257 +543 ☔ View full report in Codecov by Sentry. |
请问目前的三个failed应该如何修改? |
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
""" Yuan model tools""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这串代码建议封装成函数,避免出现2,24这样的魔鬼数字,明文模型路径等;
建议搞成参数传入;
PR types
New features
PR changes
Models
Description
添加了源2.0的模型结构、配置等相关文件