Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon 5th No.53】NSFnets (Navier-Stokes Flow nets): Physics-informed neural networks for the incompressible Navier-Stokes equations #613

Closed
wants to merge 77 commits into from
Closed

【Hackathon 5th No.53】NSFnets (Navier-Stokes Flow nets): Physics-informed neural networks for the incompressible Navier-Stokes equations #613

wants to merge 77 commits into from

Conversation

DUCH714
Copy link
Contributor

@DUCH714 DUCH714 commented Oct 30, 2023 •
edited

PR types

Others

PR changes

Others

Describe

Implementing NSFnet by PaddleScience

wangguan1995
wangguan1995 reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@wangguan1995 wangguan1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need fix

examples/NSFNet/VP_NSFNet1.py Show resolved Hide resolved
examples/NSFNet/VP_NSFNet1.py Outdated Show resolved Hide resolved
examples/NSFNet/VP_NSFNet1.py Outdated Show resolved Hide resolved
examples/NSFNet/VP_NSFNet1.py Outdated Show resolved Hide resolved
examples/NSFNet/VP_NSFNet1.py Outdated Show resolved Hide resolved
examples/NSFNet/VP_NSFNet1.py Outdated Show resolved Hide resolved
examples/NSFNet/VP_NSFNet1.py Outdated Show resolved Hide resolved
examples/NSFNet/VP_NSFNet1.py Outdated Show resolved Hide resolved
examples/NSFNet/VP_NSFNet1.py Outdated Show resolved Hide resolved
examples/NSFNet/VP_NSFNet1.py Outdated Show resolved Hide resolved
@wangguan1995
Copy link
Contributor

PR descriptions are requried

PR types:?
PR changes:?
Describe:?

@luotao1 luotao1 mentioned this pull request Oct 31, 2023
Open
@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Nov 2, 2023

Thanks for your contribution!

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Nov 2, 2023 •
edited

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@luotao1
Copy link
Collaborator

luotao1 commented Nov 2, 2023

需要通过下 code-style-check 流水线

@DUCH714
Copy link
Contributor Author

DUCH714 commented Nov 14, 2023

image
您好，已通过commit，但是code-style-check未通过

@HydrogenSulfate
Copy link
Collaborator

image 您好，已通过commit，但是code-style-check未通过

执行pre-commit run -a 试试

@DUCH714
Copy link
Contributor Author

DUCH714 commented Nov 14, 2023

image
执行结果

@wangguan1995
Copy link
Contributor

image 执行结果

去掉无用import
对NSFNet.md的不合理空格进行修复

另外CI报错原因是：
image
没有执行 pre-commit run --files $real_filepath
real_filepath="${PADDLESCIENCE_ROOT}/${file_name}"

wangguan1995
wangguan1995 reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@wangguan1995 wangguan1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need fix

examples/NSFNet/VP_NSFNet3.yaml Outdated Show resolved Hide resolved
docs/zh/examples/NSFNet.md Show resolved Hide resolved
examples/NSFNet/VP_NSFNet1_eval.py Outdated Show resolved Hide resolved
examples/NSFNet/VP_NSFNet3.py Outdated Show resolved Hide resolved
examples/NSFNet/VP_NSFNet3.py Outdated Show resolved Hide resolved
examples/NSFNet/VP_NSFNet3.py Outdated Show resolved Hide resolved
@DUCH714 DUCH714 force-pushed the develop branch 2 times, most recently from 615ebb3 to be9dac9 Compare December 4, 2023 18:43
@DUCH714
'm'
ab5ce2c 
 Please enter the commit message for your changes. Lines starting
@DUCH714
add
9209c55
@luotao1
Copy link
Collaborator

luotao1 commented Dec 12, 2023

需要解决下冲突

@DUCH714 DUCH714 mentioned this pull request Dec 12, 2023
Merged
@DUCH714
Copy link
Contributor Author

DUCH714 commented Dec 12, 2023

to #695

@DUCH714 DUCH714 closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangguan1995 wangguan1995 wangguan1995 left review comments

Assignees

@luotao1 luotao1

@wangguan1995 wangguan1995

Labels
contributor PaddlePaddle Hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DUCH714 @wangguan1995 @luotao1 @HydrogenSulfate