Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASR] fix asr cli infer #1770

Merged
merged 3 commits into from Apr 25, 2022
Merged

[ASR] fix asr cli infer #1770

merged 3 commits into from Apr 25, 2022

Conversation

Jackwaterveg
Copy link
Contributor

No description provided.

@Jackwaterveg Jackwaterveg added this to the r1.0.0a milestone Apr 24, 2022
@mergify mergify bot added the CLI label Apr 24, 2022
@mergify mergify bot added the Test label Apr 24, 2022
@@ -346,7 +346,7 @@ def _check(self, audio_file: str, sample_rate: int, force_yes: bool):
max_duration = 50.0
if audio_duration >= max_duration:
logger.error("Please input audio file less then 50 seconds.\n")
return
exit(1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cli不要调用exit类得func,需要return返回码,run func里退出。

Copy link
Collaborator

@zh794390558 zh794390558 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zh794390558 zh794390558 merged commit f118554 into PaddlePaddle:develop Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants