add fix for 3 chinese chars, and 2nd char tone should not be 5 #2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
老头子 这类词，会被分词成 老头，子。 子之前已被轻声了， 分解之后 老头这词又是属于 neural must ，头又会被轻声。所以会又两个tone 5 ，这个修复主要是改正这个。改完后测试，wer 有升高，但都是标注错误所致 |
yt605155624
reviewed
Sep 9, 2022
| @@ -156,6 +156,9 @@ def _yi_sandhi(self, word: str, finals: List[str]) -> List[str]: | |||
| return finals | |||
|
|
|||
| def _split_word(self, word: str) -> List[str]: | |||
| if len(word) == 3 and word[ | |||
| -1:] == '子': # three chars, like 老头子,the second char tone should not be 5 | |||
There was a problem hiding this comment.
a="abc"
a[-1]
'c'
a[-1:]
'c'
no difference
There was a problem hiding this comment.
you can use compare_base.py to get badcases
|
|
fixed in #2370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
PR changes
Describe