[TTS]Avoid using variable "attn_loss" before assignment #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yt605155624
reviewed
Jan 31, 2023
| @@ -113,16 +113,18 @@ def update_core(self, batch): | |||
| loss.backward() | |||
| optimizer.step() | |||
|
|
|||
| if self.use_guided_attn_loss: | |||
There was a problem hiding this comment.
good job ! Maybe you should also fix this for class Tacotron2Evaluator
yt605155624
changed the title
yt605155624
reviewed
Feb 2, 2023
| @@ -113,16 +113,18 @@ def update_core(self, batch): | |||
| loss.backward() | |||
| optimizer.step() | |||
|
|
|||
| if self.use_guided_attn_loss: | |||
| report("eval/attn_loss", float(attn_loss)) | |||
There was a problem hiding this comment.
should be train/attn_loss here
|
I have directly pushed to your branch to fix some bugs @hopingZ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
PR changes
Describe