Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Install]remove utils and third_party in paddlespeech's site-packages #2867

Merged
merged 1 commit into from Feb 1, 2023

Conversation

yt605155624
Copy link
Collaborator

@yt605155624 yt605155624 commented Feb 1, 2023

If utils and third_party are installed in python's site-packages, they will be regarded as Python third-party library, which doesn't meet our expectations.

before fix:
ad2a9f39eb8e649e816db1253585d50f
after fix:
c377bb5bf93285e710123d144f304ae5

@yt605155624 yt605155624 added this to the r1.4.0 milestone Feb 1, 2023
@yt605155624 yt605155624 self-assigned this Feb 1, 2023
Copy link
Contributor

@SmileGoat SmileGoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yt605155624 yt605155624 merged commit 896da6d into PaddlePaddle:develop Feb 1, 2023
@yt605155624 yt605155624 deleted the rm_utils_in_setup branch February 1, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants