Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix paddle.linalg.norm #2626

Merged
merged 1 commit into from
Jan 25, 2024
Merged

fix paddle.linalg.norm #2626

merged 1 commit into from
Jan 25, 2024

Conversation

zhwesky2010
Copy link
Contributor

No description provided.

@zhwesky2010 zhwesky2010 mentioned this pull request Jan 24, 2024
Merged
zbt78
zbt78 reviewed Jan 24, 2024
View reviewed changes
framework/api/linalg/test_norm.py
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在代码处于这个commit：da0d533的时候，再把test_norm9()和test_norm12()删掉，pytest test_norm.py就没问题了。因为这两个test中p=3，axis=[1,2]，想求矩阵范数，但是并不支持p=3的情况。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zbt78 已删除，这两个case在新版下确实不合法，因为矩阵向量没有p=3。现在看下pytest test_norm.py 能跑过吗

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在可以了
image

@DDDivano DDDivano merged commit c3b92d7 into PaddlePaddle:develop Jan 25, 2024
2 of 4 checks passed
@DDDivano
Copy link
Collaborator

不兼容升级，先在CI中屏蔽Case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbt78 zbt78 zbt78 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhwesky2010 @DDDivano @zbt78