Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Travis build doesn't fail when it should actually fail #335

Closed
jetfuel opened this issue Mar 23, 2018 · 1 comment
Closed

The Travis build doesn't fail when it should actually fail #335

jetfuel opened this issue Mar 23, 2018 · 1 comment
Assignees
@jetfuel

Comments

@jetfuel
Copy link
Collaborator

jetfuel commented Mar 23, 2018 •
edited
Loading

The travis build somehow always exit with 0 (success). and it didn't catch the pitfalls when it needs to be.
For example, the style check didn't pass but the travis still marked it as success.

We need to fix this to avoid troubling code gets into the codebase.
@jetfuel jetfuel self-assigned this Mar 23, 2018
@jetfuel
Copy link
Collaborator Author

jetfuel commented Mar 23, 2018

fixed by #336

@jetfuel jetfuel closed this as completed Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jetfuel jetfuel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jetfuel