Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] add scope_name definition #689

Merged
merged 3 commits into from Nov 5, 2021
Merged

[fix] add scope_name definition #689

merged 3 commits into from Nov 5, 2021

Conversation

firedent
Copy link
Contributor

@firedent firedent commented Oct 26, 2021

  1. Add scope_name definition into x2paddle/op_mapper/pytorch2paddle/aten.py. Missing scope_name will cause throwing NameError: name 'scope_name' is not defined when convert pytorch model file into paddlepaddle model file.
  2. remove some unused variables in x2paddle/op_mapper/pytorch2paddle/aten.py
  3. The outputs parameter of function graph.add_layer should be layer_outputs not current_outputs.

下面的文字请保留在PR说明的最后面,并在提完PR后,根据实际情况勾选确认以下情况

Please check the follow step before merging this pull request

  • Python code style verification
  • Review all the code diff by yourself
  • All models(TensorFLow/Caffe/ONNX/PyTorch) testing passed
  • Details about your pull request, releated issues

If this PR add new model support, please update model_zoo.md and add model to out test model zoos(@wjj19950828)

  • New Model Supported
  • No New Model Supported

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2021

CLA assistant check
All committers have signed the CLA.

@jiangjiajun
Copy link
Contributor

Hi, @firedent

Thanks for your contribution! Could you add some explanations for this pull request?

@firedent
Copy link
Contributor Author

firedent commented Nov 4, 2021

Hi, @jiangjiajun
Please check the update

  1. Add scope_name definition into x2paddle/op_mapper/pytorch2paddle/aten.py. Missing scope_name will cause throwing NameError: name 'scope_name' is not defined when convert pytorch model file into paddlepaddle model file.
  2. remove some unused variables in x2paddle/op_mapper/pytorch2paddle/aten.py
  3. The outputs parameter of function graph.add_layer should be layer_outputs not current_outputs.

下面的文字请保留在PR说明的最后面,并在提完PR后,根据实际情况勾选确认以下情况

Please check the follow step before merging this pull request

  • Python code style verification
  • Review all the code diff by yourself
  • All models(TensorFLow/Caffe/ONNX/PyTorch) testing passed
  • Details about your pull request, releated issues

If this PR add new model support, please update model_zoo.md and add model to out test model zoos(@wjj19950828)

  • New Model Supported
  • No New Model Supported

@jiangjiajun jiangjiajun merged commit 132fc6c into PaddlePaddle:develop Nov 5, 2021
@firedent firedent deleted the patch branch November 8, 2021 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants