Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix backslash misunderstood as escape character when generating code in Windows #706

Merged
merged 3 commits into from Nov 23, 2021

Conversation

dawn1206
Copy link
Contributor

@dawn1206 dawn1206 commented Nov 18, 2021

Fix wrong path representation when generating code in Windows。

Create A Good Pull Request

下面的文字请保留在PR说明的最后面,并在提完PR后,根据实际情况勾选确认以下情况

Please check the follow step before merging this pull request

  • Python code style verification
  • Review all the code diff by yourself
  • All models(TensorFLow/Caffe/ONNX/PyTorch) testing passed
  • Details about your pull request, releated issues

If this PR add new model support, please update model_zoo.md and add model to out test model zoos(@wjj19950828)

  • New Model Supported
  • No New Model Supported

@dawn1206 dawn1206 closed this Nov 18, 2021
@dawn1206 dawn1206 reopened this Nov 18, 2021
@wjj19950828
Copy link
Collaborator

@dawn1206 您好,.idea下面的内容是一定需要的吗,可以去掉吗

@dawn1206
Copy link
Contributor Author

dawn1206 commented Nov 22, 2021 via email

@wjj19950828
Copy link
Collaborator

噢不是需要的,可以去掉

---Original--- From: @.> Date: Mon, Nov 22, 2021 11:47 AM To: @.>; Cc: @.@.>; Subject: Re: [PaddlePaddle/X2Paddle] fix backslash misunderstood as escape character when generating code in Windows (PR #706) @dawn1206 您好,.idea下面的内容是一定需要的吗,可以去掉吗 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

那麻烦您再commit一下把不需要的内容去掉吧~

@dawn1206
Copy link
Contributor Author

dawn1206 commented Nov 22, 2021 via email

@dawn1206
Copy link
Contributor Author

噢不是需要的,可以去掉

---Original--- From: @.> Date: Mon, Nov 22, 2021 11:47 AM To: _@**._>; Cc: _@.@.**_>; Subject: Re: [PaddlePaddle/X2Paddle] fix backslash misunderstood as escape character when generating code in Windows (PR #706) @dawn1206 您好,.idea下面的内容是一定需要的吗,可以去掉吗 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

那麻烦您再commit一下把不需要的内容去掉吧~

您好,不需要的内容去掉了

@dawn1206
Copy link
Contributor Author

噢不是需要的,可以去掉

---Original--- From: @.> Date: Mon, Nov 22, 2021 11:47 AM To: _@**._>; Cc: _@.@.**_>; Subject: Re: [PaddlePaddle/X2Paddle] fix backslash misunderstood as escape character when generating code in Windows (PR #706) @dawn1206 您好,.idea下面的内容是一定需要的吗,可以去掉吗 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

那麻烦您再commit一下把不需要的内容去掉吧~

您好,我这边其他的代码并没有修改,就改了这一个绝对地址的地方,但是代码风格检查没有办法通过

@wjj19950828
Copy link
Collaborator

@dawn1206 您好,相关问题已反馈给QA,问题出在

if layer.kernel in ["prim.list_unpack" , "prim.tuple_unpack"]:

推荐您再commit一下,将"prim.list_unpack"后面的空格去除~

@jiangjiajun jiangjiajun merged commit d8dbf83 into PaddlePaddle:develop Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants