Fixed topk op #805
Merged
Fixed topk op #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiangjiajun
requested changes
Jun 6, 2022
| k = k[0] | ||
| if k is not None: | ||
| is_k_attr = True | ||
| layer_attrs["k"] = k |
There was a problem hiding this comment.
这里判断了k is not None，如果k是None会怎样？
There was a problem hiding this comment.
这里主要分为两种情况：k不为None，作为属性传入；k为None，作为输入传入
修改了下写法，判断k is not None以及else，Done.
There was a problem hiding this comment.
这种代码，加上注释吧。 之前的注释确实太少，现在有这种逻辑的，都加上注释说明，避免以后再回过头看代码，不清楚这个逻辑是在干啥
jiangjiajun
requested changes
Jun 6, 2022
| k = k[0] | ||
| if k is not None: | ||
| is_k_attr = True | ||
| layer_attrs["k"] = k |
There was a problem hiding this comment.
这种代码，加上注释吧。 之前的注释确实太少，现在有这种逻辑的，都加上注释说明，避免以后再回过头看代码，不清楚这个逻辑是在干啥
jiangjiajun
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create A Good Pull Request
Please check the follow step before merging this pull request
If this PR add new model support, please update
model_zoo.mdand add model to out test model zoos(@wjj19950828)Do follow contributes
1、优化topk实现，增加k为attr的实现
2、solved #803