【Hackathon No.21】 #114
Merged
【Hackathon No.21】 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR格式检查通过，你的PR将接受Paddle专家以及开源社区的review，请及时关注PR动态。 |
yingyibiao
reviewed
Apr 29, 2022
Comment on lines
76
to
77
| input:Tensor, 维度为[batchsize,num_classes] | ||
| label:Tensor, 维度为[batchsize,num_classes] |
There was a problem hiding this comment.
- input 和 label 的维度设置 [batch_size,dim] 是基于什么考虑呢？
- input 和 label 接受的 data_type 是什么样子的呢？
yingyibiao
reviewed
May 7, 2022
Comment on lines
77
to
78
| - input:Tensor, 维度为[N,*],其中N是batch_size， `*` 是任意其他维度。数据类型是float32、float64。 | ||
| - label:Tensor, 维度为[batchsize,num_classes]维度、数据类型与输入 input 相同。 |
There was a problem hiding this comment.
这里的 API 参数设计还存在一些问题：
- label 的维度应该与input的维度相同
- label 的数值只能为 1 或者 -1
- label 需要支持 [int32, int64, float32, float64] 数据类型
yingyibiao
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add rfc of SoftMarginLoss