【Hackathon 4th No.15】Add GaussianNLLLoss rfc file. #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GGBond8488
reviewed
Feb 22, 2023
| 2. 测试 CPU、GPU 上与 numpy 的一致性。 | ||
| 3. 各reduction下计算一致 | ||
| 4. 各参数输入有效。 | ||
|
|
GGBond8488
reviewed
Feb 22, 2023
| # 一、概述 | ||
|
|
||
| ## 1、相关背景 | ||
|
|
GGBond8488
reviewed
Feb 22, 2023
| @@ -0,0 +1,180 @@ | |||
| # xlogy 设计文档 | |||
There was a problem hiding this comment.
变更为paddle.nn.gaussian_nll_loss 设计文档
GGBond8488
reviewed
Feb 22, 2023
| reduction: str="mean", | ||
| name:str=None, | ||
| ) -> Tensor:` | ||
| - Input(Tensor): `(N, *)` 或 `(*)` 其中 `*`表示任何数量的额外维度 |
Atlantisming
changed the title
GGBond8488
reviewed
Feb 22, 2023
| 3. 根据 `reduction`，输出 loss（同其余 functional loss 中的实现） | ||
|
|
||
|
|
||
| # 六、测试和验收的考量 |
There was a problem hiding this comment.
这里增加对不同数据类型的测试，明确该 loss 支持的输入数据类型和输出数据类型
luotao1
approved these changes
Feb 28, 2023
This was referenced Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GaussianNLLLoss rfc file.
代码及英文文档：PaddlePaddle/Paddle#50843
中文文档：PaddlePaddle/docs#5623