【Hackathon 4th No.11】 为 paddle 新增 paddle.distribution.Geometric 分布 #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luotao1 还有一个，多谢多谢！ |
cxxly
reviewed
Feb 23, 2023
|
|
||
| `Geometric distribution` 应用条件：进行一系列独立试验，每一次试验活成功或失败，每一次试验的成功概率相同，即：为了取得第一次成功，需要进行多少次试验。 | ||
|
|
||
| 目前 Paddle 框架中没有继承 Geometric 分布。所以此任务的目标是在 Paddle 框架中，基于现有概率分布方案，在其基础上进行扩展，新增 Geometric API，API 的调用路径为： `paddle.distribution.Geometric`。 |
cxxly
reviewed
Feb 23, 2023
| ```python | ||
| #probs: the probability of sampling 1. Must be in range (0, 1] | ||
| #logits：the log-odds of sampling 1. | ||
| paddle.distribution.geometric.Geometric(probs, logits) |
There was a problem hiding this comment.
这两个参数是二选一，还是必须都传；我理解是二选一，目前Paddle只需要支持probs就行；logits如果有兴趣可以所有分布统一支持
There was a problem hiding this comment.
这两个参数是二选一，还是必须都传；我理解是二选一，目前Paddle只需要支持probs就行；logits如果有兴趣可以所有分布统一支持
- 确实是二选一，是我没有表达清楚。
- logits 的实现确实是需要额外的处理。后面能力允许的话再尝试着如何让所有分布都支持 logits。
|
@cxxly 您上面提出的修改意见都已进行修改，劳烦抽空再给review一下，感谢！ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rfc : Geometric Distribution