Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon + No.29】为 Paddle 新增 paddle.sparse.slice 稀疏 API #382

Merged
merged 4 commits into from
Mar 10, 2023

Conversation

ScottWong98
Copy link
Contributor

任务详细说明 No.29

@CLAassistant
Copy link

CLAassistant commented Feb 25, 2023

CLA assistant check
All committers have signed the CLA.

@paddle-bot
Copy link

paddle-bot bot commented Feb 25, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备,具体请参考示例模版
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@ScottWong98 ScottWong98 changed the title 【Hackathon + No.29】 + 为 Paddle 新增 paddle.sparse.slice 稀疏 API 【Hackathon + No.29】为 Paddle 新增 paddle.sparse.slice 稀疏 API Feb 25, 2023
const std::vector<int64_t>& axes,
const phi::IntArray& starts,
const phi::IntArray& ends,
const std::vector<int64_t>& infer_flags,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infer_flags/ decrease_flas这两个参数可以不需要,尽量与Python API一致


# 六、测试和验收的考量

检查 **axes**, **starts** 和 **ends** 的合法性,包括
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以大致写下需要测试哪些场景的case

Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants