【Hackathon 4 No.16】为 Paddle 新增 PoissonNLLLoss API #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LyndonKong
force-pushed
the
poissonnllloss
branch
4 times, most recently
from
59ea691
to
7ab5020
Compare
LyndonKong
force-pushed
the
poissonnllloss
branch
from
7ab5020
to
c6b0401
Compare
GGBond8488
reviewed
Mar 2, 2023
|
|
||
| # 四、对比分析 | ||
|
|
||
| 设计方案将参考PyTorch的实现，在当前版本的API当中仅实现Python版本，对于PyTorch实现中部分抛弃的参数不再做兼容。 |
|
|
||
| ## 1、相关背景 | ||
|
|
||
| paddle.nn.PoissonNLLLoss 和 paddle.nn.functional.Poisson_nll_loss API 用于泊松分布的负对数似然函数的计算。 |
There was a problem hiding this comment.
这个“用于泊松分布的负对数似然函数的计算” 描述不太合适
| \text{loss}(\text{input}, \text{target}) = \text{input} - \text{target} * \log(\text{input}) + \log(\text{target!}) | ||
| $$ | ||
|
|
||
| 损失函数中的最后一项可以使用Stirling公式近似，当target的值超过1时考虑此项近似，当target的值小于等于1的时候设置为0。 |
There was a problem hiding this comment.
这里是和每一个元素都是1的Tensor进行elemen-wise的比较，小于等于1的地方mask掉对应的逼近项。在PyTorch的实现中调用的是Tensor.masked_fill(mask, value)。
There was a problem hiding this comment.
在设计文档和中文文档中补充了这个说明。
LyndonKong
force-pushed
the
poissonnllloss
branch
2 times, most recently
from
74005df
to
767c243
Compare
LyndonKong
force-pushed
the
poissonnllloss
branch
from
767c243
to
be47ea8
Compare
luotao1
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PoissonNLLLoss API rfc file