【PaddlePaddle Hackathon 第四期】No.6：为 Paddle 新增 ldexp API #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luotao1
reviewed
Mar 3, 2023
| @@ -0,0 +1,169 @@ | |||
| # paddle.ldexp 设计文档 | |||
|
|
|||
| |API名称 | paddle.Idexp | | |||
There was a problem hiding this comment.
是小写的L，不是大写的i
全文都得改一下，包括文件名
| 任务 Issue: [No.6：为 Paddle 新增 ldexp API](https://github.com/PaddlePaddle/Paddle/issues/50630#task6) | ||
|
|
||
| ## 2、功能目标 | ||
| 增加API `paddle.ldexp` 和 `paddle.Tensor.ldexp`，实现 `ldexp(double x, int exponent)`函数，函数返回 x 乘以 2 的 exponent 次幂 |
There was a problem hiding this comment.
实现
ldexp(double x, int exponent)函数，
下面参数设计里写的是，请对齐
paddle.ldexp(
input: Tensor,
other: Tensor
)
| 1. 使用`paddle.exp`对输入exponent，进行以自然数 e 为底指数运算 | ||
| 2. 将步骤1得到的值乘以x即可 | ||
|
|
||
| 但在实际实现时，不能完全直接复用上述方案，理由如下： |
There was a problem hiding this comment.
将步骤1得到的值乘以x即可
这个对么，paddle.exp是e为底，paddle.ldexp是2为底
| paddle.ldexp( | ||
| input: Tensor, | ||
| other: Tensor | ||
| ) |
|
|
||
| ## 七、可行性分析及规划排期 | ||
| 具体规划： | ||
| - 阶段一：完成API功能开放 |
|
@luotao1 修改好了～,辛苦review下 |
luotao1
reviewed
Mar 6, 2023
|
|
||
| # 五、设计思路与实现方案 | ||
|
|
||
| ## 命名与参数设计 | ||
| 添加 API | ||
| ```python | ||
| paddle.ldexp( | ||
| input: Tensor, | ||
| other: Tensor | ||
| input: 多纬Tensor，数据类型为 float16 、 float32 、 float64 、 int32 或 int64 |
luotao1
reviewed
Mar 7, 2023
| 任务 Issue: [No.6：为 Paddle 新增 ldexp API](https://github.com/PaddlePaddle/Paddle/issues/50630#task6) | ||
|
|
||
| ## 2、功能目标 | ||
| 增加API `paddle.ldexp` 和 `paddle.Tensor.ldexp`，实现 `ldexp(input, other)`函数，函数返回 x 乘以 2 的 other 次幂 |
There was a problem hiding this comment.
2 的 other 次幂，下面数据类型变了，这里可以强调下是整数幂
| 添加 API | ||
| ```python | ||
| paddle.ldexp( | ||
| input: 多纬Tensor，数据类型为 float32 、 float64 、 int32 或 int64 |
There was a problem hiding this comment.
多纬Tensor-》多维，为什么这里去掉float16呢
There was a problem hiding this comment.
因为我测试代码的时候，发现我目前实现方式是不支持float16😭
There was a problem hiding this comment.
因为我测试代码的时候，发现我目前实现方式是不支持float16
好的
| input * 2^{other} | ||
| $$ | ||
|
|
||
| 通过调研发现，Paddle 本身已实现 paddle.pow 可以计算2的整数次幂函数，可利用paddle.pow API 与 input 相乘实现 paddl.lexp。 |
luotao1
reviewed
Mar 8, 2023
| @@ -123,8 +123,8 @@ math_ldexp_impl(PyObject *module, double x, PyObject *i) | |||
| 添加 API | |||
| ```python | |||
| paddle.ldexp( | |||
| input: 多纬Tensor，数据类型为 float32 、 float64 、 int32 或 int64 | |||
| other: 多维Tensor，数据类型为 int32 或 int64 | |||
| input: 多纬Tensor，数据类型为 float32、float64、int32 或 int64 | |||
| @@ -137,7 +137,7 @@ $$ | |||
| input * 2^{other} | |||
| $$ | |||
|
|
|||
| 通过调研发现，Paddle 本身已实现 paddle.pow 可以计算2的整数次幂函数，可利用paddle.pow API 与 input 相乘实现 paddl.lexp。 | |||
| 通过调研发现，Paddle 本身已实现 paddle.pow 可以计算2的整数次幂函数，可利用paddle.pow API 与 input 相乘实现 paddl.ldexp。 | |||
There was a problem hiding this comment.
paddl.ldexp -》paddle.ldexp
|
修改好了～ |
luotao1
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【PaddlePaddle Hackathon 第四期】No.6：为 Paddle 新增 ldexp API