【Hackathon4 No.40】为 Paddle 优化 kthvalue op 在 GPU 上的计算性能 #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesLim-sy
reviewed
Mar 14, 2023
| | Case No. | device | input_shape | input_type | k | Paddle Perf(ms) | | ||
| |---|---|---|---|---|---| | ||
| | 1 | RTX 2070s | [16L, 10000L] | float32 | 5 | 0.29134 | | ||
| | 2 | RTX 2070s | [16L, 3000L] | float32 | 1 | 0.13398 | |
There was a problem hiding this comment.
@JamesLim-sy 目前该算子还不支持float16, 所以运行float16的benchamark会报错。
RuntimeError: (NotFound) The kernel with key (GPU, Undefined(AnyLayout), float16) of kernel kthvalue is not registered and fail to fallback to CPU one. Selected wrong DataType float16. Paddle support following DataTypes: float32, int64, float64, int32.
[Hint: Expected kernel_iter != iter->second.end(), but received kernel_iter == iter->second.end().] (at /paddle/paddle/phi/core/kernel_factory.cc:219)
There was a problem hiding this comment.
中加入phi::dtype::float16 的类型注册，再测试 FP16性能
There was a problem hiding this comment.
@JamesLim-sy 已添加fp16性能测试
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
为 Paddle 优化 kthvalue op 在 GPU 上的计算性能