Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 4th No.7】为 Paddle 新增 Unflatten API #460

Merged
merged 10 commits into from
Mar 20, 2023

Conversation

@paddle-bot
Copy link

paddle-bot bot commented Mar 14, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备,具体请参考示例模版
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@cos43 cos43 changed the title 【Hackathon 4th No.13】为 Paddle 新增 Unflatten API 【Hackathon 4th No.7】为 Paddle 新增 Unflatten API Mar 14, 2023
@cos43
Copy link
Contributor Author

cos43 commented Mar 15, 2023

@luotao1

@cos43
Copy link
Contributor Author

cos43 commented Mar 15, 2023

我这个可以帮我review一下吗

rfcs/APIs/20230314_api_design_for_unflatten.md Outdated Show resolved Hide resolved
rfcs/APIs/20230314_api_design_for_unflatten.md Outdated Show resolved Hide resolved
rfcs/APIs/20230314_api_design_for_unflatten.md Outdated Show resolved Hide resolved
rfcs/APIs/20230314_api_design_for_unflatten.md Outdated Show resolved Hide resolved
rfcs/APIs/20230314_api_design_for_unflatten.md Outdated Show resolved Hide resolved
rfcs/APIs/20230314_api_design_for_unflatten.md Outdated Show resolved Hide resolved
rfcs/APIs/20230314_api_design_for_unflatten.md Outdated Show resolved Hide resolved
@cos43
Copy link
Contributor Author

cos43 commented Mar 17, 2023

我这个可以帮我review一下吗

能帮忙再看看嘛

rfcs/APIs/20230314_api_design_for_unflatten.md Outdated Show resolved Hide resolved
rfcs/APIs/20230314_api_design_for_unflatten.md Outdated Show resolved Hide resolved
rfcs/APIs/20230314_api_design_for_unflatten.md Outdated Show resolved Hide resolved
rfcs/APIs/20230314_api_design_for_unflatten.md Outdated Show resolved Hide resolved
rfcs/APIs/20230314_api_design_for_unflatten.md Outdated Show resolved Hide resolved
rfcs/APIs/20230314_api_design_for_unflatten.md Outdated Show resolved Hide resolved
@cos43
Copy link
Contributor Author

cos43 commented Mar 17, 2023

我这个可以帮我review一下吗

在单元测试这里,我列出了异常情况(包含正常情况)和边界情况,我只给出了参数的例子,完整的例子我没有给出。

@cos43
Copy link
Contributor Author

cos43 commented Mar 17, 2023

已经修改,paddle.reshape支持paddle里面的所有数据类型,['uint8', 'int8', 'int16', 'int32', 'int64', 'float32', 'float64', 'float16', 'bfloat16', 'complex64','complex128', 'bool']

@cos43
Copy link
Contributor Author

cos43 commented Mar 18, 2023

我这个可以帮我review一下吗

在单元测试这里,我列出了异常情况(包含正常情况)和边界情况,我只给出了参数的例子,完整的例子我没有给出。

今天还可以帮我review吗

Copy link
Contributor

@zoooo0820 zoooo0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
Copy link
Collaborator

luotao1 commented Apr 25, 2023

4、产生任务 leader:第一个通过设计文档评审的开发者将成为该任务的 leader,后续任务开发需按照设计文档进行;若其他开发者先于任务 leader 提交了作品,则他/她的作品需经过任务 leader 的确认(自@任务leader review 后,7个自然日内无回复默认通过),未按照设计文档开发的作品将不会进入评审阶段。

https://aistudio.baidu.com/aistudio/competition/detail/776/0/introduction

cos43 review 下这个PR,同时关注下上述规则(by 2023年4月25日)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants