【Hackathon4 No.33】为 Paddle 优化 Histogram op 在 GPU 上的计算性能 #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JamesLim-sy 老师，麻烦review一下，已经两个周了，(:з」∠) |
JamesLim-sy
reviewed
Apr 17, 2023
|
|
||
| ## 2.1 关键模块与性能提升点 | ||
|
|
||
| 关键是使用`phi::funcs::ReduceKernel`，加速`Histogram`确定直方图边界的计算部分，从而提高`Histogram`算子在GPU上的计算性能。预期能够平均提升2倍以上。 |
There was a problem hiding this comment.
Paddle内置的Reduce计算目前针对的场景是单输入、单输出，不建议使用。鉴于Min Max是一体两面的计算，一个__device__ Kernel 内部可以同时得到Max_value 和 Min_value，另外如果对 cooperative_groups 或其他同类内存栅栏有了解的话，可以统一在一个 global kernel 内部完成全部计算.
JamesLim-sy
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
为 Paddle 优化 Histogram op 在 GPU 上的计算性能
任务：PaddlePaddle/Paddle#50657 (comment)