【Hackathon4 No.39】为 Paddle 优化 p_norm_grad op 在 GPU 上的计算性能 #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
呜呜呜，老师这个也抽空看看吧，已经三周了，(:з」∠) @JamesLim-sy |
|
麻烦老师抽空看看吧， @JamesLim-sy |
JamesLim-sy
reviewed
Apr 27, 2023
|
|
||
| ## 2.1 关键模块与性能提升点 | ||
|
|
||
| `p_norm_grad`算子的性能瓶颈在于Eigen实现了整个计算过程，在查阅了相关源码之后，确定可以使用`ElementWiseKernel`和`BroadcastKernel`对Eigen的实现进行替换，并结合一些计算融合的方法，减少`Kernel`的调用，提高`p_norm_grad`算子在GPU的计算性能。 |
There was a problem hiding this comment.
Ele和Bc确实能够提升OP的整体性能，那是否可以实现单个Kernel解决全部问题的方案
There was a problem hiding this comment.
额，这个方案不可行么，那我研究研究融合进一个kernel的方法
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
为 Paddle 优化 p_norm_grad op 在 GPU 上的计算性能
任务：PaddlePaddle/Paddle#50657 (comment)