【Hackathon 6th Fundable Projects No.2】 引入clang-tidy #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
【Hackathon 6th】Fundable Projects 引入clang-tidy
luotao1
reviewed
May 15, 2024
|
|
||
| 注意：以下规则检测基于2024.5.13的`paddlepaddle`的`develop`分支以及`pytorch`的检查规则 | ||
|
|
||
| 首先，我们将`paddlepaddle`编译`cmake`之后,我们使用`clang-tidy`的并行检查工具进行扫描，使用的规则便是`pytorch`设置的规则 |
There was a problem hiding this comment.
pytorch未设置的规则，Paddle后续是否要设置？
There was a problem hiding this comment.
这部分我今晚列入到pytorch工作结束之后的后续工作当中
|
|
||
| 得到总 error错误数量为：**9148** | ||
|
|
||
| 整理一下各模块的错误数量，如下所示： |
There was a problem hiding this comment.
- 需要在正文里补充下之前的工作的结论： 20230501_introducing_clang_tidy.md 和 赛题四：在飞桨框架中引入 clang-tidy Tracking Issue Paddle#54073
There was a problem hiding this comment.
这部分内容我增加一个前置工作说明！
|
收到涛姐
发自我的iPhone
…------------------ 原始邮件 ------------------
发件人: Tao Luo ***@***.***>
发送时间: 2024年5月15日 12:03
收件人: PaddlePaddle/community ***@***.***>
抄送: fanhaoxuee ***@***.***>, Author ***@***.***>
主题: Re: [PaddlePaddle/community] 【Hackathon 6th NO.2】 引入clang-tidy (PR #900)
@luotao1 commented on this pull request.
In rfcs/CodeStyle/20240514_introducing_clang_tidy.md:
> + ' + HeaderFilterRegex: '^(paddle/(?!cinn)).*$' + AnalyzeTemporaryDtors: false + WarningsAsErrors: '*' + ... + ``` + + 而展开来看的话，pytorch支持**246**种规则的检查，规则数量在使用`clang-tidy`并行检查工具之后可以得到，并且要及时更新。 + + + +### `clang-tidy`进行存量扫描 + +注意：以下规则检测基于2024.5.13的`paddlepaddle`的`develop`分支以及`pytorch`的检查规则 + +首先，我们将`paddlepaddle`编译`cmake`之后,我们使用`clang-tidy`的并行检查工具进行扫描，使用的规则便是`pytorch`设置的规则
pytorch未设置的规则，Paddle后续是否要设置？
In rfcs/CodeStyle/20240514_introducing_clang_tidy.md:
> +> -extra-arg=-Wno-unused-variable \ +> -extra-arg=-Wno-overloaded-virtual \ +> -extra-arg=-Wno-defaulted-function-deleted \ +> -extra-arg=-Wno-delete-non-abstract-non-virtual-dtor \ +> -extra-arg=-Wno-return-type-c-linkage > clang-tidy.log 2>&1 +``` + +检索`clang-tidy.log`文件： + +```shell +grep "error:" clang-tidy.log | wc -l +``` + +得到总 error错误数量为：**9148** + +整理一下各模块的错误数量，如下所示：
需要在正文里补充下之前的工作的结论： 20230501_introducing_clang_tidy.md 和 PaddlePaddle/Paddle#54073
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
ApricityXX
changed the title
Galaxy1458
approved these changes
May 16, 2024
|
luotao1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【Hackathon 6th】Fundable Projects 引入clang-tidy
对应的 tracking issue：PaddlePaddle/Paddle#64128