Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

add script for models repo stable #36

Merged
merged 1 commit into from
May 10, 2018

Conversation

guochaorong
Copy link
Collaborator

resolve #28

@guochaorong guochaorong requested a review from Superjomn May 9, 2018 06:57
@guochaorong guochaorong merged commit 2fa0240 into PaddlePaddle:develop May 10, 2018
@guochaorong guochaorong deleted the models branch May 10, 2018 08:03
print('kpi:%s' % kpi_name)
if self.analysis_result[kpi_name]['change_rate'] > self.diff_thre:
suc = False
print("kpi: %s change_tate too bigger !!!!!!!!!!" % kpi_name)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is tate?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change_rate~~

suc = False
print("kpi: %s change_tate too bigger !!!!!!!!!!" % kpi_name)
else:
print('kpi:%s' % kpi_name)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

: 后面留空格

@@ -14,26 +15,63 @@ $ceroot=config.workspace
os.environ['ceroot'] = config.workspace


def RunCmd(cmd, shellformat=True):
"""run local cmd"""
p = subprocess.Popen(cmd, shell=shellformat, close_fds=True, stdin=subprocess.PIPE, \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use native XONSH

if args.task_dir:
tasks = args.task_dir.split()
return tasks
ret, out, err = RunCmd('''cd tasks; git diff HEAD^ HEAD | grep "diff --git" | awk -F' ' {'print $4'}''')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用 XONSH,不需要再增加一种执行cmd的方法

熟悉XONSH http://xon.sh/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok~ thank you

tasks = get_changed_tasks(args)
times = args.times
for task in tasks:
try:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里直接挂了退出就可以了,不需要用try

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里等所有模型都跑完,输出所有错误模型再通知,似乎更好一些?~

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

自动稳定性验证
3 participants