Update new_op_cn.md #136
Merged
Update new_op_cn.md #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanyi15
requested review from
jetfuel and
sneaxiy
and removed request for
jetfuel
|
请问是否有预览呢@tink2123 |
|
这篇文档可能还有些其他的格式问题（看现在官网0.15.0的文档），这次一起检查好了更新一下吧 |
|
@shanyi15 好的~那我现在统一调整一下这篇的格式 |
sneaxiy
reviewed
Oct 11, 2018
doc/fluid/dev/new_op_cn.md
Outdated
| @@ -150,8 +150,9 @@ class MulOp : public framework::OperatorWithKernel { | |||
|
|
|||
| protected: | |||
| void InferShape(const framework::InferShapeContext &ctx) const override { | |||
| auto dim0 = ctx.Input<Tensor>("X")->dims(); | |||
| auto dim1 = ctx.Input<Tensor>("Y")->dims(); | |||
| //never use Input or Output if you want a to get a LoDTensor. | |||
There was a problem hiding this comment.
Change it to be "never use Input<Tensor> or Output<Tensor> if you want a to get a LoDTensor."
sneaxiy
reviewed
Oct 11, 2018
doc/fluid/dev/new_op_cn.md
Outdated
| @@ -201,16 +202,18 @@ MulOp(const std::string &type, const framework::VariableNameMap &inputs, | |||
| - 与`InferShapeContext`相比，`ExecutionContext`增加了设备类型，同样可获取到输入输出和属性参数。 | |||
| - `Compute`函数里实现`OpKernel`的具体计算逻辑。 | |||
|
|
|||
| Op的输入和输出可分别通过ExecutionContext::Input()和ExecutionContext::Output()获得。注意：若op的输入/输出的变量类型是LoDTensor（fluid默认所有的Tensor默认都是LoDTensor类型），请写成ExecutionContext::Input()和ExecutionContext::Output()，不要写ExecutionContext::Input()和ExecutionContext::Output()。因为若实际的变量类型为SelectedRows，Input()和Output()方法会将SelectedRows类型特化为Tensor，导致潜在的错误。 | |||
There was a problem hiding this comment.
Op的输入和输出可分别通过ExecutionContext::Input<T>()和ExecutionContext::Output<T>()获得。注意：若op的输入/输出的变量类型是LoDTensor（fluid默认所有的Tensor默认都是LoDTensor类型），请写成ExecutionContext::Input<LoDTensor>()和ExecutionContext::Output<LoDTensor>()，不要写ExecutionContext::Input<Tensor>()和ExecutionContext::Output<Tensor>()。因为若实际的变量类型为SelectedRows，Input<Tensor>()和Output<Tensor>()方法会将SelectedRows类型特化为Tensor，导致潜在的错误。
|
完成内容修正与格式调整，预览效果如下： |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #132