Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reorder the api #243

Merged
merged 7 commits into from
Oct 29, 2018
Merged

reorder the api #243

merged 7 commits into from
Oct 29, 2018

Conversation

tink2123
Copy link
Collaborator

No description provided.

@tink2123
Copy link
Collaborator Author

fix #237

@shanyi15
Copy link
Contributor

看到大写、小写的分开来排了，大写和小写的api之间是否有区别呢？请 @luotao1 看下
image
image

@luotao1
Copy link
Collaborator

luotao1 commented Oct 29, 2018

大小写并不需要分开排序，统一排序即可。

@tink2123
Copy link
Collaborator Author

好的~

luotao1
luotao1 reviewed Oct 29, 2018
View reviewed changes
Copy link
Collaborator

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请问这个手工调，还是改了gen_doc.sh脚本呢？如果改了脚本，可以将修改内容提PR上来

@tink2123
Copy link
Collaborator Author

@luotao1 已提交脚本修改

luotao1
luotao1 approved these changes Oct 29, 2018
View reviewed changes
Copy link
Collaborator

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shanyi15
shanyi15 approved these changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@shanyi15 shanyi15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@shanyi15 shanyi15 merged commit c50b6ed into PaddlePaddle:develop Oct 29, 2018
@shanyi15 shanyi15 mentioned this pull request Oct 30, 2018
Closed
@tink2123 tink2123 deleted the reorder_api branch November 1, 2018 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@shanyi15 shanyi15 shanyi15 approved these changes

Assignees
No one assigned
Labels
API Reference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tink2123 @shanyi15 @luotao1