【Hackathon 6th No.4】Add ormqr docs API to Paddle -part #6587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感谢你贡献飞桨文档，文档预览构建中，Docs-New 跑完后即可预览，预览链接：http://preview-pr-6587.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html |
docs/api/paddle/linalg/ormqr_cn.rst
Outdated
Comment on lines
8
to
9
| 计算一个普通矩阵与 Householder 矩阵的乘积。计算维度为(m, n)的矩阵 C（由 :attr:`other` 给出）和一个矩阵 Q 的乘积， | ||
| 其中 Q 由 Householder 反射系数 (:attr:`x`, :attr:`tau`) 表示。 |
There was a problem hiding this comment.
这句话优化一下吧，计算...。计算... 一开始看有点懵，不知道是计算哪个，我理解后面的文字是对前面的补充？那么文字上就优化一下
docs/api/paddle/linalg/ormqr_cn.rst
Outdated
|
|
||
| - **x** (Tensor) - 输入一个或一批方阵，类型为 Tensor。 ``x`` 的形状应为 ``[*, MN, K]``，其中 ``*`` 为零或更大的批次维度，数据类型支持 float32， float64。 | ||
| - **tau** (Tensor) - 输入一个或一批 Householder 反射系数，类型为 Tensor。 ``tau`` 的形状应为 ``[*, min(MN, K)]``，其中 ``*`` 为零或更大的批次维度，数据类型支持 float32， float64。 | ||
| - **other ** (Tensor) - 输入一个或一批方阵，类型为 Tensor。 ``other`` 的形状应为 ``[*, M, N]``，其中 ``*`` 为零或更大的批次维度，数据类型支持 float32， float64。 |
There was a problem hiding this comment.
Suggested change
| - **other ** (Tensor) - 输入一个或一批方阵，类型为 Tensor。 ``other`` 的形状应为 ``[*, M, N]``，其中 ``*`` 为零或更大的批次维度，数据类型支持 float32， float64。 | |
| - **other** (Tensor) - 输入一个或一批方阵，类型为 Tensor。 ``other`` 的形状应为 ``[*, M, N]``，其中 ``*`` 为零或更大的批次维度，数据类型支持 float32， float64。 |
docs/api/paddle/linalg/ormqr_cn.rst
Outdated
| 参数 | ||
| :::::::::::: | ||
|
|
||
| - **x** (Tensor) - 输入一个或一批方阵，类型为 Tensor。 ``x`` 的形状应为 ``[*, MN, K]``，其中 ``*`` 为零或更大的批次维度，数据类型支持 float32， float64。 |
There was a problem hiding this comment.
方阵 会带来误解，方阵是指行数和列数相等的矩阵。想表示 matrix 就统一用 矩阵，下面也是一样
There was a problem hiding this comment.
方阵会带来误解，方阵是指行数和列数相等的矩阵。想表示 matrix 就统一用矩阵，下面也是一样
已经修改好了
luotao1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr：PaddlePaddle/Paddle#63227
rfc：PaddlePaddle/community#855