Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make edl controller jobparser workable #7

Merged
merged 7 commits into from
Mar 15, 2018

Conversation

typhoonzero
Copy link
Collaborator

Fix #6 and add some examples.

name: example
spec:
#image: "paddlepaddle/paddlecloud-job"
image: "typhoon1986/paddlecloud-job:wuyitest"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can keep the official Docker image.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@typhoonzero typhoonzero requested a review from putcn March 13, 2018 12:12
kind: Deployment
metadata:
name: training-job-controller
namespace: paddlecloud
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to create the namespace before this yaml can claim?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. We should update the documents later.

@putcn
Copy link
Collaborator

putcn commented Mar 13, 2018

excellent! I was trying the same yesterday to make the whole thing work. also, to make the training job work as CRD, do we just need to change the yaml(thirdpartyresource.yaml) or there are go code need to change with that?

helinwang
helinwang previously approved these changes Mar 13, 2018
Copy link
Contributor

@helinwang helinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM++

WORKDIR $GOPATH/src/github.com/paddlepaddle/edl
RUN glide install --strip-vendor
ADD . $GOPATH/src/github.com/paddlepaddle/edl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is the correct solution.

containers:
- name: training-job-controller
image: paddlepaddle/edl-controller
imagePullPolicy: Never
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we change the policy to IfNotPresent?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

helinwang pushed a commit to helinwang/edl that referenced this pull request Mar 14, 2018
@typhoonzero
Copy link
Collaborator Author

excellent! I was trying the same yesterday to make the whole thing work. also, to make the training job work as CRD, do we just need to change the yaml(thirdpartyresource.yaml) or there are go code need to change with that?

@putcn Yes, I'm afraid we have to put the CRD implement in another branch, it should have a lot of difference from this one.

Copy link
Collaborator

@putcn putcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@typhoonzero typhoonzero merged commit aad36bc into elasticdeeplearning:develop Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants