Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme with usage guidance. #9

Merged
merged 6 commits into from
Mar 15, 2018

Conversation

putcn
Copy link
Collaborator

@putcn putcn commented Mar 13, 2018

fix: #1
Please do NOT merge until #7 is merged.
will add training job creating guidance.

helinwang
helinwang previously approved these changes Mar 14, 2018
Copy link
Contributor

@helinwang helinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM++!

Copy link
Collaborator

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one minor comment.

then push it to docker hub to be accessible by Kubernetes:

``` bash
docker push yourRepoName/my_edl_training_job
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add git clone command before head so that readers are not confused by yourRepoName

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, will update with "Resource Adjustments by EDL" part and FAQ in next PR

@typhoonzero typhoonzero merged commit c338f06 into elasticdeeplearning:develop Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "how to run on MiniKube"
3 participants