add 3 augmentor class and relate unittest #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisxu2016
changed the title
xinghai-sun
requested changes
Jun 27, 2017
deep_speech_2/data_utils/audio.py
Outdated
| @@ -321,21 +321,19 @@ def normalize_online_bayesian(self, | |||
| gain_db = target_db - rms_estimate_db | |||
| self.apply_gain(gain_db) | |||
|
|
|||
| def resample(self, target_sample_rate, quality='sinc_medium'): | |||
| def resample(self, target_sample_rate, filter='kaiser_best'): | |||
There was a problem hiding this comment.
What is the difference between sinc_median and kaiser_best? Please make sure that they have equivalent effects.
There was a problem hiding this comment.
有差别，因为这两种resample使用的拟合函数不一样，但是实际效果差不多
| """ | ||
|
|
||
| def __init__(self, rng, min_speed_rate, max_speed_rate): | ||
|
|
|
|
||
| def __init__(self, rng, min_speed_rate, max_speed_rate): | ||
|
|
||
| if (min_speed_rate < 0.5): |
There was a problem hiding this comment.
Remove "(" and ")". The same in L28.
|
|
||
| def __init__(self, rng, min_speed_rate, max_speed_rate): | ||
|
|
||
| if (min_speed_rate < 0.5): |
There was a problem hiding this comment.
- 0.5 or 0.9? It is inconsistent with the error message.
- Please also add this explanation in function doc.
| :param audio: Audio segment to add effects to. | ||
| :type audio: AudioSegment|SpeechSegment | ||
| """ | ||
| audio_segment.resample(self._new_sample_rate) |
There was a problem hiding this comment.
"No newline at the end of file" ?
xinghai-sun
requested changes
Jun 27, 2017
| @@ -7,6 +7,9 @@ | |||
| import random | |||
| from data_utils.augmentor.volume_perturb import VolumePerturbAugmentor | |||
| from data_utils.augmentor.shift_perturb import ShiftPerturbAugmentor | |||
| from data_utils.augmentor.speed_perturb import SpeedPerturbAugmentor | |||
| from data_utils.augmentor.resample import ResampleAugmentor | |||
| from data_utils.augmentor.online_bayesian_normalization import OnlineBayesianNormalizationAugmentor | |||
There was a problem hiding this comment.
Is this longer than 80 columns?
| @@ -14,20 +14,21 @@ class SpeedPerturbAugmentor(AugmentorBase): | |||
|
|
|||
| :param rng: Random generator object. | |||
| :type rng: random.Random | |||
| :param min_speed_rate: Lower bound of new speed rate to sample. | |||
| :param min_speed_rate: Lower bound of new speed rate to sample and should | |||
| not below 0.9. | |||
There was a problem hiding this comment.
--> should not be below
| :param rng: Random generator object. | ||
| :type rng: random.Random | ||
| :param min_speed_rate: Lower bound of new speed rate to sample and should | ||
| not below 0.9. |
There was a problem hiding this comment.
--> should not be smaller than
| not below 0.9. | ||
| :type min_speed_rate: float | ||
| :param max_speed_rate: Upper bound of new speed rate to sample and should | ||
| not above 1.1. |
There was a problem hiding this comment.
--> should not be larger than
| audio_seg = audio.AudioSegment(audio_data, samplerate) | ||
| aug_pipeline.transform_audio(audio_seg) | ||
| orig_audio = audio.AudioSegment(audio_data, samplerate) | ||
| self.assertFalse(np.any(audio_seg.samples == orig_audio.samples)) |
There was a problem hiding this comment.
It's meaningless to do such a "non-equal" test. Just please remove this Augmentor unitest.
xinghai-sun
approved these changes
Jun 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #107
add VolumePerturbAugmentor, SpeedPerturbAugmentor, ResampleAugmentor, online_bayesian_normalization class for audio augmentation
change the module of resample ， original module：scikits.samplerate ， new module： resampy