Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme in DS2 #195

Merged
merged 2 commits into from
Aug 10, 2017
Merged

Update readme in DS2 #195

merged 2 commits into from
Aug 10, 2017

Conversation

kuke
Copy link
Collaborator

@kuke kuke commented Aug 10, 2017

Remove the limitation of cuDNN version due to the bug fix

@kuke kuke requested a review from xinghai-sun August 10, 2017 03:58
@kuke kuke assigned pkuyym and unassigned pkuyym Aug 10, 2017
@kuke kuke requested a review from pkuyym August 10, 2017 03:58
Copy link
Contributor

@xinghai-sun xinghai-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend to remove the whole Prerequisites.

@@ -5,7 +5,7 @@
### Prerequisites

- **Python = 2.7** only supported;
- **cuDNN >= 6.0** is required to utilize NVIDIA GPU platform in the installation of PaddlePaddle, and the **CUDA toolkit** with proper version suitable for cuDNN. The cuDNN library below 6.0 is found to yield a fatal error in batch normalization when handling utterances with long duration in inference.
- **cuDNN** library is required to utilize NVIDIA GPU platform sufficiently in the installation of PaddlePaddle, and the **CUDA toolkit** with proper version suitable for cuDNN.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Python 2.7 and cuDNN is already required when installing PaddlePaddle, we don't have to claim them again.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with that

@@ -5,7 +5,7 @@
### Prerequisites

- **Python = 2.7** only supported;
- **cuDNN >= 6.0** is required to utilize NVIDIA GPU platform in the installation of PaddlePaddle, and the **CUDA toolkit** with proper version suitable for cuDNN. The cuDNN library below 6.0 is found to yield a fatal error in batch normalization when handling utterances with long duration in inference.
- **cuDNN** library is required to utilize NVIDIA GPU platform sufficiently in the installation of PaddlePaddle, and the **CUDA toolkit** with proper version suitable for cuDNN.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can specify some version for proper version

@kuke kuke merged commit 2aaedcd into PaddlePaddle:develop Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants